Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For R.C. - Fleet UI: Add copy for policy tied to install software #25247

Merged
merged 1 commit into from
Jan 8, 2025
Merged

For R.C. - Fleet UI: Add copy for policy tied to install software #25247

merged 1 commit into from
Jan 8, 2025
+62 −7

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Jan 8, 2025 •
edited
Loading

#25245 part of #22813

 1141  git pull fleetdm main
 1142  git fetch fleetdm 
 1143  git checkout fleetdm/rc-minor-fleet-v4.62.0
 1144  git log main
 1145  git cherry-pick 3c634dfb14541a2b828500129bb4aaeb39dc6224
 1146  git checkout -b 22813-unreleased-install-software-copy-rc
 1147  git push -u fleetdm 22813-unreleased-install-software-copy-rc

@RachelElysia RachelElysia requested review from rachaelshaw and a team as code owners January 8, 2025 16:13
@RachelElysia RachelElysia changed the base branch from main to rc-minor-fleet-v4.62.0 January 8, 2025 16:18
@RachelElysia RachelElysia removed request for a team and rachaelshaw January 8, 2025 16:18
@RachelElysia RachelElysia changed the title For R.C. - For R.C. - Fleet UI: Add copy for policy tied to install software Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (rc-minor-fleet-v4.62.0@95acb6e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...d/components/PlatformSelector/PlatformSelector.tsx 85.71% 1 Missing ⚠️
frontend/hooks/usePlatformSelector.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.62.0   #25247   +/-   ##
=========================================================
  Coverage                          ?   54.30%           
=========================================================
  Files                             ?     1614           
  Lines                             ?   153552           
  Branches                          ?     3976           
=========================================================
  Hits                              ?    83392           
  Misses                            ?    63279           
  Partials                          ?     6881
Flag Coverage Δ
frontend 53.26% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia merged commit 4ffcbce into rc-minor-fleet-v4.62.0 Jan 8, 2025
28 of 30 checks passed
@RachelElysia RachelElysia deleted the 22813-unreleased-install-software-copy-rc branch January 8, 2025 16:47
@RachelElysia
Copy link
Member Author

Merged with only awaiting go tests for github action (EM approved cc: @mostlikelee)

This was referenced Jan 13, 2025
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahzielv jahzielv jahzielv approved these changes

@iansltx iansltx iansltx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RachelElysia @iansltx @jahzielv